Clean tests + Fix newline and UTF8 support#39
Open
JValck wants to merge 1 commit into
Open
Conversation
|
This seems like a good pr will merge in my branch, fork, with few adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pervious PR (#38 ) wrongly detected binary strings as UTF-8.
Reverting to ff617a0 is not a good option as this would still leave the UTF-8 unfixed (see #38 ).
This PR also supports
\n,\t,\r,... in custom attributes in the models.The single (big) test class is now split up in multiple smaller classes to improve testability and readability.
The new functionality is tested, so it is save to draft a new release.